GIT: unionfs2-2.6.27.y: fs/unionfs/: Remove alloc_filldir_node

Erez Zadok ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:15:52 EDT 2010


commit 9c04939070aa98ff1177a4547b7486ffe305e28e
Author: Josef 'Jeff' Sipek <jsipek at cs.sunysb.edu>
Date:   Sun Feb 25 17:30:34 2007 -0500

    fs/unionfs/: Remove alloc_filldir_node
    
    alloc_filldir_node was used only once. Additionally, all the arguments
    passed to it were ignored wasting stack space for no reason whatsoever.
    
    Signed-off-by: Josef 'Jeff' Sipek <jsipek at cs.sunysb.edu>

diff --git a/fs/unionfs/rdstate.c b/fs/unionfs/rdstate.c
index e240285..b67a86a 100644
--- a/fs/unionfs/rdstate.c
+++ b/fs/unionfs/rdstate.c
@@ -225,12 +225,6 @@ struct filldir_node *find_filldir_node(struct unionfs_dir_state *rdstate,
 	return cursor;
 }
 
-static struct filldir_node *alloc_filldir_node(const char *name, int namelen,
-					       unsigned int hash, int bindex)
-{
-	return kmem_cache_alloc(unionfs_filldir_cachep, GFP_KERNEL);
-}
-
 int add_filldir_node(struct unionfs_dir_state *rdstate, const char *name,
 		     int namelen, int bindex, int whiteout)
 {
@@ -246,7 +240,7 @@ int add_filldir_node(struct unionfs_dir_state *rdstate, const char *name,
 	index = hash % rdstate->size;
 	head = &(rdstate->list[index]);
 
-	new = alloc_filldir_node(name, namelen, hash, bindex);
+	new = kmem_cache_alloc(unionfs_filldir_cachep, GFP_KERNEL);
 	if (!new) {
 		err = -ENOMEM;
 		goto out;


More information about the unionfs-cvs mailing list