GIT: unionfs2-2.6.27.y: bugfix in BUG_ON use: actually catch bad use of unionfs_mntput

Erez Zadok ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:16:14 EDT 2010


commit 5b92645f81d3249d3a3d79fa78d4a4341598d82c
Author: Erez_Zadok <ezk at cs.sunysb.edu>
Date:   Fri May 11 01:51:48 2007 -0400

    bugfix in BUG_ON use: actually catch bad use of unionfs_mntput

diff --git a/fs/unionfs/union.h b/fs/unionfs/union.h
index 3652277..9b54ed5 100644
--- a/fs/unionfs/union.h
+++ b/fs/unionfs/union.h
@@ -480,13 +480,13 @@ static inline void unionfs_mntput(struct dentry *dentry, int bindex)
 	if (!dentry) {
 		if (bindex < 0)
 			return;
-		BUG_ON(dentry && bindex < 0);
+		BUG_ON(!dentry && bindex >= 0);
 	}
 	mnt = unionfs_lower_mnt_idx(dentry, bindex);
 	if (!mnt) {
 		if (bindex < 0)
 			return;
-		BUG_ON(mnt && bindex < 0);
+		BUG_ON(!mnt && bindex >= 0);
 	}
 	mntput(mnt);
 }


More information about the unionfs-cvs mailing list