GIT: unionfs2-2.6.27.y: bug fix: don't revalidate dropped dentries

Erez Zadok ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:16:16 EDT 2010


commit 4b0a058c27cce0ee7a38329bf5ea458979787edc
Author: Erez Zadok <ezk at bigvaio.(none)>
Date:   Fri May 18 01:53:12 2007 -0400

    bug fix: don't revalidate dropped dentries
    
    This fixes a harmless but annoying message that unionfs prints if a dropped
    dentry is being revalidated, which could happen if you unlink open files.

diff --git a/fs/unionfs/commonfops.c b/fs/unionfs/commonfops.c
index ab92cac..519dbf0 100644
--- a/fs/unionfs/commonfops.c
+++ b/fs/unionfs/commonfops.c
@@ -331,9 +331,12 @@ int unionfs_file_revalidate(struct file *file, int willwrite)
 	unionfs_lock_dentry(dentry);
 	sb = dentry->d_sb;
 
-	/* first revalidate the dentry inside struct file */
-	if (!__unionfs_d_revalidate_chain(dentry, NULL) &&
-	    !d_deleted(dentry)) {
+	/*
+	 * First revalidate the dentry inside struct file,
+	 * but not unhashed dentries.
+	 */
+	if (!d_deleted(dentry) &&
+	    !__unionfs_d_revalidate_chain(dentry, NULL)) {
 		err = -ESTALE;
 		goto out_nofree;
 	}


More information about the unionfs-cvs mailing list