GIT: unionfs2-2.6.27.y: bug fix: catch bad use of dirs= options (extra ':' separators)

Erez Zadok ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:16:27 EDT 2010


commit 6debc9db28dcd19ff91902811b9309cb7fff20c9
Author: Erez_Zadok <ezk at cs.sunysb.edu>
Date:   Fri May 25 17:01:00 2007 -0400

    bug fix: catch bad use of dirs= options (extra ':' separators)
    
    Signed-off-by: Erez Zadok <ezk at cs.sunysb.edu>

diff --git a/fs/unionfs/main.c b/fs/unionfs/main.c
index decefef..a690182 100644
--- a/fs/unionfs/main.c
+++ b/fs/unionfs/main.c
@@ -320,8 +320,12 @@ static int parse_dirs_option(struct super_block *sb, struct unionfs_dentry_info
 		int perms;
 		char *mode = strchr(name, '=');
 
-		if (!name || !*name)
+		if (!name)
 			continue;
+		if (!*name) {	/* bad use of ':' (extra colons) */
+			err = -EINVAL;
+			goto out;
+		}
 
 		branches++;
 


More information about the unionfs-cvs mailing list