GIT: unionfs2-2.6.27.y: Unionfs: remove unnecessary lower atime updates
Erez Zadok
ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:17:24 EDT 2010
commit 58269eae26ac8d509c2d23440a1c82d46f572286
Author: Erez Zadok <ezk at cs.sunysb.edu>
Date: Sun Nov 11 18:34:34 2007 -0500
Unionfs: remove unnecessary lower atime updates
No need for this because our readpage calls vfs_read on the lower objects,
which would update the atime as/if needed.
Signed-off-by: Erez Zadok <ezk at cs.sunysb.edu>
diff --git a/fs/unionfs/file.c b/fs/unionfs/file.c
index 126df5e..809e0f1 100644
--- a/fs/unionfs/file.c
+++ b/fs/unionfs/file.c
@@ -31,10 +31,6 @@ static ssize_t unionfs_read(struct file *file, char __user *buf,
err = do_sync_read(file, buf, count, ppos);
- if (err >= 0)
- touch_atime(unionfs_lower_mnt(file->f_path.dentry),
- unionfs_lower_dentry(file->f_path.dentry));
-
out:
unionfs_read_unlock(file->f_path.dentry->d_sb);
unionfs_check_file(file);
@@ -58,10 +54,6 @@ static ssize_t unionfs_aio_read(struct kiocb *iocb, const struct iovec *iov,
if (err == -EIOCBQUEUED)
err = wait_on_sync_kiocb(iocb);
- if (err >= 0)
- touch_atime(unionfs_lower_mnt(file->f_path.dentry),
- unionfs_lower_dentry(file->f_path.dentry));
-
out:
unionfs_read_unlock(file->f_path.dentry->d_sb);
unionfs_check_file(file);
diff --git a/fs/unionfs/mmap.c b/fs/unionfs/mmap.c
index bb00fd5..34fd8aa 100644
--- a/fs/unionfs/mmap.c
+++ b/fs/unionfs/mmap.c
@@ -212,12 +212,6 @@ static int unionfs_readpage(struct file *file, struct page *page)
err = unionfs_do_readpage(file, page);
- if (!err) {
- touch_atime(unionfs_lower_mnt(file->f_path.dentry),
- unionfs_lower_dentry(file->f_path.dentry));
- unionfs_copy_attr_times(file->f_path.dentry->d_inode);
- }
-
/*
* we have to unlock our page, b/c we _might_ have gotten a locked
* page. but we no longer have to wakeup on our page here, b/c
More information about the unionfs-cvs
mailing list