GIT: unionfs2-2.6.27.y: Unionfs: update times in setattr

Erez Zadok ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:17:28 EDT 2010


commit a5699bae5e85cf490b772e47f2747314d0e6e195
Author: Erez Zadok <ezk at cs.sunysb.edu>
Date:   Sat Nov 24 16:03:14 2007 -0500

    Unionfs: update times in setattr
    
    Needed to maintain Unix semantics via utimes(2).
    
    Signed-off-by: Erez Zadok <ezk at cs.sunysb.edu>

diff --git a/fs/unionfs/inode.c b/fs/unionfs/inode.c
index ef61d9c..63ff3d3 100644
--- a/fs/unionfs/inode.c
+++ b/fs/unionfs/inode.c
@@ -1090,6 +1090,18 @@ static int unionfs_setattr(struct dentry *dentry, struct iattr *ia)
 	/* get the size from the first lower inode */
 	lower_inode = unionfs_lower_inode(inode);
 	unionfs_copy_attr_all(inode, lower_inode);
+	/*
+	 * unionfs_copy_attr_all will copy the lower times to our inode if
+	 * the lower ones are newer (useful for cache coherency).  However,
+	 * ->setattr is the only place in which we may have to copy the
+	 * lower inode times absolutely, to support utimes(2).
+	 */
+	if (ia->ia_valid & ATTR_MTIME_SET)
+		inode->i_mtime = lower_inode->i_mtime;
+	if (ia->ia_valid & ATTR_CTIME)
+		inode->i_ctime = lower_inode->i_ctime;
+	if (ia->ia_valid & ATTR_ATIME_SET)
+		inode->i_atime = lower_inode->i_atime;
 	fsstack_copy_inode_size(inode, lower_inode);
 	/* if setattr succeeded, then parent dir may have changed */
 	unionfs_copy_attr_times(dentry->d_parent->d_inode);


More information about the unionfs-cvs mailing list