GIT: unionfs2-2.6.27.y: Unionfs: release special files on copyup

Erez Zadok ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:17:35 EDT 2010


commit 60ba85732ae69553d4920db1612e6c7cbc1c59c0
Author: Erez Zadok <ezk at cs.sunysb.edu>
Date:   Tue Dec 18 19:14:46 2007 -0500

    Unionfs: release special files on copyup
    
    If we copyup a special file (char, block, etc.), then dput the source
    object.
    
    Signed-off-by: Erez Zadok <ezk at cs.sunysb.edu>

diff --git a/fs/unionfs/copyup.c b/fs/unionfs/copyup.c
index 3fe4865..f48209f 100644
--- a/fs/unionfs/copyup.c
+++ b/fs/unionfs/copyup.c
@@ -505,13 +505,12 @@ out_unlock:
 
 out_free:
 	/*
-	 * If old_lower_dentry was a directory, we need to dput it.  If it
-	 * was a file, then it was already dput indirectly by other
+	 * If old_lower_dentry was not a file, then we need to dput it.  If
+	 * it was a file, then it was already dput indirectly by other
 	 * functions we call above which operate on regular files.
 	 */
 	if (old_lower_dentry && old_lower_dentry->d_inode &&
-	    (S_ISDIR(old_lower_dentry->d_inode->i_mode) ||
-	     S_ISLNK(old_lower_dentry->d_inode->i_mode)))
+	    !S_ISREG(old_lower_dentry->d_inode->i_mode))
 		dput(old_lower_dentry);
 	kfree(symbuf);
 


More information about the unionfs-cvs mailing list