GIT: unionfs2-2.6.27.y: Unionfs: remove unnecessary lock in read_inode

Erez Zadok ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:17:37 EDT 2010


commit d4c2a601cdc3d4aaf6063b574d6c65c311fa5e9d
Author: Erez Zadok <ezk at cs.sunysb.edu>
Date:   Thu Dec 20 23:14:44 2007 -0500

    Unionfs: remove unnecessary lock in read_inode
    
    Our read_inode doesn't need to grab the superblock rwsem because there no
    chance it could be affected by branch management.  But our read_inode was
    called from other places which did grab need to grab that rwsem, and lockdep
    complained.
    
    Signed-off-by: Erez Zadok <ezk at cs.sunysb.edu>

diff --git a/fs/unionfs/super.c b/fs/unionfs/super.c
index c474c86..8b70aca 100644
--- a/fs/unionfs/super.c
+++ b/fs/unionfs/super.c
@@ -29,8 +29,6 @@ static void unionfs_read_inode(struct inode *inode)
 	int size;
 	struct unionfs_inode_info *info = UNIONFS_I(inode);
 
-	unionfs_read_lock(inode->i_sb);
-
 	memset(info, 0, offsetof(struct unionfs_inode_info, vfs_inode));
 	info->bstart = -1;
 	info->bend = -1;
@@ -63,7 +61,6 @@ static void unionfs_read_inode(struct inode *inode)
 	inode->i_mtime.tv_sec = inode->i_mtime.tv_nsec = 0;
 	inode->i_ctime.tv_sec = inode->i_ctime.tv_nsec = 0;
 
-	unionfs_read_unlock(inode->i_sb);
 }
 
 /*


More information about the unionfs-cvs mailing list