[Unionfs] unionfs mmap diff

Shaya Potter spotter at cs.columbia.edu
Thu Mar 2 16:04:21 EST 2006


On Thu, 2006-03-02 at 15:47 -0500, Erez Zadok wrote:
> Are you sure it's against 1.1.3?  If so, why did you reintroduce fist.h?
> Make sure your "before" and "after" source trees are clean of old cruft.

actually not used.  artifact from wrapfs origins.

> For this large patch, we need explanations.  Every fxn you changed, added,
> or removed -- why?  Why did you "#if 0" a number of things?

this was to not remove code, but to just disable it, so that future
patching would work (fuzz)

> You can stick comments such as "//SP: text..." above each code block you
> touched, so we can easily read the explanation of your change along with the
> relevant code (and grep out your comments before applying such code :-)

no problem.




More information about the unionfs mailing list