[Unionfs] errno bug about xattr

hooanon05 at yahoo.co.jp hooanon05 at yahoo.co.jp
Sun Mar 5 16:44:54 EST 2006


Latest unionfs snapshot seems to support xattr, but there is a tiny
bug. It stops basic copyup feature.
I don't know it depends upon branch filesystem or not, ie. lower xattr
routines return ENOTSUPP or EOPNOTSUPP.
Here is a patch.

Junjiro Okajima

--- unionfs-20060304-1620/copyup.c	5 Mar 2006 20:58:55 -0000	1.1
+++ unionfs-20060304-1620/copyup.c	5 Mar 2006 21:33:27 -0000	1.2
@@ -103,8 +103,9 @@ static int copyup_xattrs(struct dentry *
 		xattr_free(name_list, list_size + 1);
 	if (attr_value)
 		xattr_free(attr_value, XATTR_SIZE_MAX);
+	print_exit_status(err);
 	/* It is no big deal if this fails, we just roll with the punches. */
-	if (err == -ENOTSUPP)
+	if (err == -ENOTSUPP || err == -EOPNOTSUPP)
 		err = 0;
 	return err;
 }



More information about the unionfs mailing list