GIT: unionfs2-2.6.27.y: IPoIB: Fix world-writable child interface control sysfs attributes

Erez Zadok ezk at fsl.cs.sunysb.edu
Thu Aug 12 23:15:37 EDT 2010


commit 2e06c6e67bf3bbc63f8603fe9d71106e0fab28ad
Author: Or Gerlitz <ogerlitz at voltaire.com>
Date:   Sun Jun 6 04:59:16 2010 +0000

    IPoIB: Fix world-writable child interface control sysfs attributes
    
    commit 7a52b34b07122ff5f45258d47f260f8a525518f0 upstream.
    
    Sumeet Lahorani <sumeet.lahorani at oracle.com> reported that the IPoIB
    child entries are world-writable; however we don't want ordinary users
    to be able to create and destroy child interfaces, so fix them to be
    writable only by root.
    
    Signed-off-by: Or Gerlitz <ogerlitz at voltaire.com>
    Signed-off-by: Roland Dreier <rolandd at cisco.com>
    Signed-off-by: Greg Kroah-Hartman <gregkh at suse.de>

diff --git a/drivers/infiniband/ulp/ipoib/ipoib_main.c b/drivers/infiniband/ulp/ipoib/ipoib_main.c
index e9ca3cb..fb97c42 100644
--- a/drivers/infiniband/ulp/ipoib/ipoib_main.c
+++ b/drivers/infiniband/ulp/ipoib/ipoib_main.c
@@ -1158,7 +1158,7 @@ static ssize_t create_child(struct device *dev,
 
 	return ret ? ret : count;
 }
-static DEVICE_ATTR(create_child, S_IWUGO, NULL, create_child);
+static DEVICE_ATTR(create_child, S_IWUSR, NULL, create_child);
 
 static ssize_t delete_child(struct device *dev,
 			    struct device_attribute *attr,
@@ -1178,7 +1178,7 @@ static ssize_t delete_child(struct device *dev,
 	return ret ? ret : count;
 
 }
-static DEVICE_ATTR(delete_child, S_IWUGO, NULL, delete_child);
+static DEVICE_ATTR(delete_child, S_IWUSR, NULL, delete_child);
 
 int ipoib_add_pkey_attr(struct net_device *dev)
 {


More information about the unionfs-cvs mailing list